Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kv/bulk: fix kvBuf test #78242

Merged
merged 1 commit into from
Mar 22, 2022
Merged

kv/bulk: fix kvBuf test #78242

merged 1 commit into from
Mar 22, 2022

Conversation

dt
Copy link
Member

@dt dt commented Mar 22, 2022

x 'fits' in y if less than or equal, not just less; the code had this right but the
test did not.

Release note: none.

x 'fits' in y if less than _or equal_, not just less; the code had this right but the
test did not.

Release note: none.
@dt dt requested a review from adityamaru March 22, 2022 11:59
@dt dt requested a review from a team as a code owner March 22, 2022 11:59
@cockroach-teamcity
Copy link
Member

This change is Reviewable

@dt dt linked an issue Mar 22, 2022 that may be closed by this pull request
@dt dt mentioned this pull request Mar 22, 2022
@dt
Copy link
Member Author

dt commented Mar 22, 2022

TFTR!

bors r+

@craig
Copy link
Contributor

craig bot commented Mar 22, 2022

Build succeeded:

@craig craig bot merged commit b2a16b0 into cockroachdb:master Mar 22, 2022
@dt dt deleted the buf-mem-test-flake branch March 23, 2022 19:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

kv/bulk: TestKvBuf failed
3 participants